Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CookData::getStaminaRecoverValue -> getEffectDurationFrames #132

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Rename CookData::getStaminaRecoverValue -> getEffectDurationFrames #132

merged 1 commit into from
Dec 30, 2024

Conversation

Pistonight
Copy link
Collaborator

@Pistonight Pistonight commented Dec 26, 2024 •
edited by leoetlino
Loading

I looked into this for botw-recipe, which cross-referenced CookingMgr, CookData.byml, and values I get in game. The getStaminaRecoverValue name is definitely incorrect, since mEffectDuration has nothing to do with stamina (see the comments in code). Given it's multiplying duration in seconds by 30, I am guessing it's duration in frames

This change is Reviewable

leoetlino
leoetlino approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@leoetlino leoetlino merged commit d5128f8 into zeldaret:master Dec 30, 2024
3 checks passed
@Pistonight Pistonight deleted the update_cookdata_comment branch December 31, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoetlino leoetlino leoetlino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pistonight @leoetlino