New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String decoding fix for Ice Spear using cp1252 #5

Closed

NiceneNerd wants to merge 1 commit into zeldamods:master from NiceneNerd:master

NiceneNerd commented Jan 7, 2020

Proposed solution for issue #4


          String decoding fix for Ice Spear using cp1252

e78f6db

Member

leoetlino commented Jan 7, 2020

Nintendo doesn't use CP1252 for BYML as far as I know, and this only masks a byaml-lib bug in Ice Spear that was fixed several months ago: https://gitlab.com/ice-spear-tools/byaml-lib/commit/0dae2d16cf87adf3fcfe13a2455a4599b75a7858

leoetlino closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet