Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for building new archives #2

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Added support for building new archives #2

merged 1 commit into from
Sep 30, 2018

Conversation

bravely-beep
Copy link
Contributor

@bravely-beep bravely-beep commented Sep 29, 2018

This does indeed build my new .sbactorpack archive, but it breaks something else - if I include edits to TitleBG.pack in the patch files, it becomes impossible to pick up one-handed swords off the ground. Strangely, this still happens even if the patch files in TitleBG.pack are identical to the originals. I checked, and the TitleBG.pack built by the patcher was identical to the original, so the error has to be in a different file - maybe the RSTB?

@leoetlino
Copy link
Member

Hmm, that seems really weird. I can't see anything wrong with your changes...

Have you tried comparing the generated RSTBs?

@bravely-beep
Copy link
Contributor Author

Turns out I misdiagnosed the issue:

If I don't add a new archive, I get no errors ever, using PR1 and PR2
If I do add a new archive, it obviously doesn't work at all with PR1, and using PR2 causes the picking-up-swords glitch
From now on I'll only use the PR2 build of the patcher
Running the patcher with a new archive, then deleting the new sbactorpack from the built files, will still cause the error
TitleBG doesn't seem to affect anything

@bravely-beep
Copy link
Contributor Author

Confirmed that the issue is with rstbtool, not the patcher
Should be okay to merge this then

@bravely-beep bravely-beep changed the title Added glitchy support for building new archives Added support for building new archives Sep 30, 2018
@leoetlino leoetlino merged commit b0130d0 into zeldamods:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants