Bridge Explorer implementation #80
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1 @@ | |||
| v16.14.2 | |||
There was a problem hiding this comment.
Probably we want to update to at least node18 since 16 is no longer supports by a lot of libraries these days
Comment on lines
+6
to
+7
| "@dcspark/cip5-js": "^1.0.0", | ||
| "@emurgo/cip14-js": "^3.0.1", |
There was a problem hiding this comment.
We don't need these two anymore since they're Cardano specific
| "@testing-library/jest-dom": "^5.16.4", | ||
| "@testing-library/react": "^13.0.1", | ||
| "@testing-library/user-event": "^13.5.0", | ||
| "algosdk": "^1.21.0", |
There was a problem hiding this comment.
Don't need this since it's Algorand specific
| "buffer": "^6.0.3", | ||
| "clsx": "^1.2.1", | ||
| "crypto-browserify": "^3.12.0", | ||
| "ethers": "^5.6.4", |
There was a problem hiding this comment.
Don't need this since it's EVM-specific
| "react-scripts": "5.0.1", | ||
| "react-simple-pull-to-refresh": "1.3.3", | ||
| "serve": "^13.0.2", | ||
| "typescript": "^4.6.3", |
There was a problem hiding this comment.
Probably want to upgrade to typescript v5 since many tools require it these days
Comment on lines
+114
to
+117
| public static isEvmTxIdAsync = (txId: string) => { | ||
| // try basic regex, to just validate if tx is valid evm tx id | ||
| return /^0x([A-Fa-f0-9]{64})$/.test(txId); | ||
| }; |
There was a problem hiding this comment.
Needs to be a Mina tx id check
Comment on lines
+119
to
+133
| public static isCardanoAddress = (address: string) => { | ||
| try { | ||
| // Not sure what should be the limit for Cardano Addresses? | ||
| // Also not sure if I should use serialization-lib vs just bech32 decoding | ||
| // for detecing if its a valid cardano address | ||
| const bech32Info = bech32.decode(address, 1000); | ||
| if (bech32Info.prefix === Cip5.miscellaneous.addr) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } | ||
| } catch (e) { | ||
| return false; | ||
| } | ||
| }; |
| import { BridgeTransferResponse } from "./Services/BridgeService"; | ||
|
|
||
| export enum SearchInputType { | ||
| EvmAddress = "evmAddress", |
| } | ||
|
|
||
| export type ProcessedBridgeRequestResponse = BridgeTransferResponse & { | ||
| // symbol?: string; |
| @@ -0,0 +1,12 @@ | |||
| { | |||
| "c1-devnet": { | |||
There was a problem hiding this comment.
the name of the keys in this object need to be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked from Milkomeda bridge explorer as requested. There are still Milkomeda assets, as I haven't found any usable graphics for Zeko etc...
Some components still to be changed, e.g. Search functionality, will do that swiftly after I can get the real data.