Bridge zkApp implementation #79
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejos
force-pushed
the
matejos/bridge-zkapp
branch
from
1d5fd52 to
b14038b
Compare
Comment on lines
21
to
40
| /* | ||
| const transactionJSON = await workerClient!.createBridgeTransaction({ | ||
| amount, | ||
| direction, | ||
| sender, | ||
| target, | ||
| }); | ||
|
|
||
| const { hash } = await window.mina!.sendTransaction({ | ||
| transaction: transactionJSON, | ||
| feePayer: { | ||
| fee: transactionFee, | ||
| memo: "", | ||
| }, | ||
| }); | ||
|
|
||
| const transactionLink = `https://berkeley.minaexplorer.com/transaction/${hash}`; | ||
| console.log(`View transaction at ${transactionLink}`); | ||
| */ | ||
| await timeout(5); |
There was a problem hiding this comment.
Just leaving a comment here to note which parts need to be filled in later
| import { PublicKey } from "o1js"; | ||
| import { useAppStore } from "../configs/store"; | ||
|
|
||
| const KNOWN_ERROR_CODES: number[] = [20005, 1002]; |
There was a problem hiding this comment.
Where do these come from? Magic numbers are not great, so at the very least we should have a comment
| sender: account.publicKey, | ||
| target: targetAddress, | ||
| }); | ||
| // todo: mechanism that is waiting for tx confirmation and will edit stored txn status via editStoredTransaction |
There was a problem hiding this comment.
Just taking notes of which functions we need to fill in later
MartinOndejka
force-pushed
the
matejos/bridge-zkapp
branch
from
c7580aa to
ba8e58e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much everything is prepared for when the sequencer is ready to be used for transaction generation.