Fix transfer claim #214
Draft
Fix transfer claim #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really sure this PR is worth reviewing for issues or bugs, or mistakes, or merging, because the design is outdated. |
L-as
reviewed
Sep 18, 2024
| @@ -209,6 +209,11 @@ module Process_transfer = struct | |||
| (* We give it permission *) | |||
| ; implicit_account_creation_fee = | |||
| Boolean.false_ (* Custom token account, can't be true *) | |||
| ; events = | |||
L-as
reviewed
Sep 18, 2024
| let before = List.map ~f:(value_to_actions TR.typ) before in | ||
| let after = List.map ~f:(value_to_actions TR.typ) after in | ||
| let%bind trans1 = | ||
| Action_state_extension.prove ~dummy:is_new ~source:pointer before | ||
| Action_state_extension.prove ~dummy:is_new | ||
| ~source:Zkapp_account.Actions.empty_state_element before |
There was a problem hiding this comment.
pretty sure this is somewhat wrong, somewhat right, but it isn't worth it I think
|
can't you mock it without the changes if you set the permissions to Either? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2 issues:
This PR requires the change to the inner account VK, and forced state root update in outer account.