Draft
Conversation
The libraries seem like dependencies, so instead of making linking them conditional (which could lead to undefined symbols during link later if they are not present) link them unconditionally (which would fail during the configure phase).
Do not use the default value, but instead the fully instantiated variable for the concrete build.
Use C++ header
Prefer defaulting functions
Prefer using helper functions
Prefer defaulting functions
Drop unused function.
This reverts commit b135646.
Remove unused function.
Remove an unused function instead of attempting to fix it. The version previously on this branch did introduce a new race in that it properly created a new temporary file without clash, but then renamed it. Since the function is unused we don't need to deal with that.
It wasn't clear previously whether the two output files were indeed on the same filesystem, but they should be now. Also clean up some of the variables.
Reduce repeated string allocations (not critical here).
This reverts commit 676ba70.
These libraries are real dependencies, so instead of making the link conditional on the CMake targets being there, always link them to make any errors explicit.
We would previously ignore the `default_` in the passed `Allocator`. Ideally we'd also have a test for this, but punting on that for now.
Hopefully this is less obscure than core-golfing ADL workarounds.
Reduce duplication.
We already require C++20 so the feature macro should be available. With that in mind remove some duplication.
Merging this PR will degrade performance by 5.37%
Performance Changes
Comparing 
|
Move to upstream branch again.
Use current revision of the repo.
bbannier
force-pushed
the
topic/bbannier/windows
branch
from
381a064 to
84cd941
Compare
Use current revision of the repo.
Use current revision of the repo.
Use current revision of the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.