Allow empty splits on panes #40245
Draft
Allow empty splits on panes #40245
+213
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding an enum for SplitBehavior (naming not final) to support bindings like `["pane::SplitLeft", {"behavior": "Empty"}]`
- subsuming SplitAndMoveDirection actions but probably have to keep them (?)
- empty behavior for terminal panes: unclear what this means. Currently split but does not clone.
cla-bot
bot
added
the
cla-signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as a base for continuing the discussion in #8008 : adds a
SplitBehaviorenum to support bindings like["pane::SplitLeft", {"behavior": "Empty"}]To be discussed @MrSubidubi and others:
Emptyis unclear, e.g., what does this mean for terminal panes? Added placeholder code to split without cloning, but unsure what users would expect in this case.SplitAndMoveXyzactions but I guess we should keep them for backwards compatibility?crates/collab/src/tests/integration_tests.rs?Closes #8008
Release Notes:
pane::Splitbehavior ({Clone,Empty,Move}) to allow creating an empty buffer.