fs: Replace a bunch of uses of smol::fs with manual impls #40172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
project Co-authored-by: Smit Barmase <[email protected]>
Co-authored-by: Smit Barmase <[email protected]>
This reverts commit 30f9d85.
…mpl" This reverts commit 7710ab6.
This reverts commit d0fcfe7.
osiewicz
force-pushed
the
fs-use-bg-executor
branch
from
c68c59a to
50aaf89
Compare
osiewicz
added a commit
that referenced
this pull request
Oct 16, 2025
osiewicz
added a commit
that referenced
this pull request
Oct 16, 2025
This caused issues with #40172, as it made Zed execute and block on tad few more background tasks. Parker is ~cheap to create, hence we should be ok to just create it at the time it is needed.
osiewicz
added a commit
that referenced
this pull request
Oct 16, 2025
This caused issues with #40172, as it made Zed execute and block on tad few more background tasks. Parker is ~cheap to create, hence we should be ok to just create it at the time it is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smol::fs uses a separate threadpool, which is a bit yuck.
This PR also added a benchmark you can use to run a full worktree scan (initial one, that is) for arbitrary worktree.. and refactored worktree scanner to use async locks, as otherwise tests were deadlocking. :)
I've benchmarked it against Zed, Linux and Chromium and saw a ~60% drop in initial worktree scan times across the board.
Release Notes: