settings ui: Improve rendering performance #40001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
The scroll bar is not the correct size in the settings ui in all states
P1n3appl3
pushed a commit
to P1n3appl3/zed
that referenced
this pull request
Oct 18, 2025
This PR improves the rendering performance of the Settings UI window by using `gpui::list` to render only the visible contents of a settings page, instead of rendering the full content of a page. This fixes a lag that the editor page has in debug builds. I also added a new field `measuring_behavior` to `ListState` that has `Visible` and `Measured` variances. `Visible` only measures and caches the bounds of visible items plus the overdraw pixel offset. `Measure` will cache all items’ bounds on the first layout phase, which fixes problems with the scrollbar size/position being miscalculated. Release Notes: - N/A --------- Co-authored-by: Mikayla Maki <[email protected]> Co-authored-by: Ben Kunkle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the rendering performance of the Settings UI window by using
gpui::listto render only the visible contents of a settings page, instead of rendering the full content of a page. This fixes a lag that the editor page has in debug builds.I also added a new field
measuring_behaviortoListStatethat hasVisibleandMeasuredvariances.Visibleonly measures and caches the bounds of visible items plus the overdraw pixel offset.Measurewill cache all items’ bounds on the first layout phase, which fixes problems with the scrollbar size/position being miscalculated.Release Notes: