Skip to content

markdown: Add support for inline HTML img tags inside text #37264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 8, 2025
+172 −86
Merged

markdown: Add support for inline HTML img tags inside text #37264

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dbfd090
Apply feedback from previous PR
RemcoSmitsDev Aug 31, 2025
d98cd19
Add support for inline images
RemcoSmitsDev Aug 31, 2025
cfa6896
Remove styling preparation code
RemcoSmitsDev Aug 31, 2025
a4c8e7e
Fix rare panic
RemcoSmitsDev Aug 31, 2025
e476d14
Fix wrapping with inline images
RemcoSmitsDev Sep 1, 2025
c3860f3
Minify markdown to remove newlines & specify capacity for links
RemcoSmitsDev Sep 3, 2025
730b1cb
Merge branch 'main' into markdown-support-inline-elements
RemcoSmitsDev Sep 3, 2025
d27656d
Revert "Minify markdown to remove newlines & specify capacity for links"
RemcoSmitsDev Sep 3, 2025
8b8186a
Undo flex wrap logic
RemcoSmitsDev Sep 4, 2025
3163088
Revert "Undo flex wrap logic"
RemcoSmitsDev Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/markdown_preview/src/markdown_elements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ pub struct ParsedMarkdownText {
/// Where the text is located in the source Markdown document.
pub source_range: Range<usize>,
/// The text content stripped of any formatting symbols.
pub contents: String,
pub contents: SharedString,
/// The list of highlights contained in the Markdown document.
pub highlights: Vec<(Range<usize>, MarkdownHighlight)>,
/// The regions of the various ranges in the Markdown document.
Expand Down
Loading
Loading