vim: Don't push scrolls to nav history

[dovakin0007]

Closes #17592

Release Notes:

• Added Don't push to nav history while scrolling in Vim mode

Untitled.video.-.Made.with.Clipchamp.mp4

[zed-industries-bot]

	Warnings
⚠️	This PR is missing release notes. Please add a "Release Notes" section that describes the change: Release Notes: - Added/Fixed/Improved ... If your change is not user-facing, you can use "N/A" for the entry: Release Notes: - N/A

Generated by 🚫 dangerJS against e6c6792

[dovakin0007]

@ConradIrwin please do let me know what are the changes can be done and whether the given approach is the right one thank you

[timmclean]

I was looking into jumplist issues in Zed this week with @danielcressman so I thought I'd chime in here.

There are a bunch of bugs related to the jumplist in vim mode. The overall problem is that there is a mismatch between how vim manages its jumplist vs how Zed in vim mode manages its jumplist. I think all of these bugs could be resolved at the same time by aligning Zed's vim mode behaviour to match vim.

In Zed, it seems that any navigation action can count as a "jump":

• Scrolling: Don't push to nav history when scrolling #17592
• Page up/down: vim: PageUp, PageDown, ScrollUp, ScrollDown should not be added to the jumplist. #29431
• j and k (e.g. 15j)
• Clicking somewhere in the editor

However, Zed requires that the navigation change the cursor position by at least MIN_NAVIGATION_HISTORY_ROW_DELTA lines, which is hardcoded to 10 in the codebase. This prevents e.g. single line movements from adding to the jumplist.

In vim, whether a navigation is a "jump" is determined entirely based on the type of movement. This means that even a single line move can count as a jump if it is the right type of motion, while a 100-line move may not count as a jump if it is not the right type of motion.

In other words, there are 2 types of problems right now with Zed's jumplist: situations where it adds to the jumplist but shouldn't, and situations where it doesn't add to the jumplist but it should (e.g. #30183).

In my view, Zed should match vim's jumplist behaviour by default when Zed is in vim mode. This would mean eliminating the use of MIN_NAVIGATION_HISTORY_ROW_DELTA (while in vim mode, at least), and adding entries to the jumplist only when the navigation is of the right type.

[dovakin0007]

I was looking into jumplist issues in Zed this week with @danielcressman so I thought I'd chime in here.

There are a bunch of bugs related to the jumplist in vim mode. The overall problem is that there is a mismatch between how vim manages its jumplist vs how Zed in vim mode manages its jumplist. I think all of these bugs could be resolved at the same time by aligning Zed's vim mode behaviour to match vim.

In Zed, it seems that any navigation action can count as a "jump":

However, Zed requires that the navigation change the cursor position by at least MIN_NAVIGATION_HISTORY_ROW_DELTA lines, which is hardcoded to 10 in the codebase. This prevents e.g. single line movements from adding to the jumplist.

In vim, whether a navigation is a "jump" is determined entirely based on the type of movement. This means that even a single line move can count as a jump if it is the right type of motion, while a 100-line move may not count as a jump if it is not the right type of motion.

In other words, there are 2 types of problems right now with Zed's jumplist: situations where it adds to the jumplist but shouldn't, and situations where it doesn't add to the jumplist but it should (e.g. #30183).

In my view, Zed should match vim's jumplist behaviour by default when Zed is in vim mode. This would mean eliminating the use of MIN_NAVIGATION_HISTORY_ROW_DELTA (while in vim mode, at least), and adding entries to the jumplist only when the navigation is of the right type.

I have pushed the changes for these any suggestions will be really helpful

• Scrolling: Don't push to nav history when scrolling #17592
• Page up/down: vim: PageUp, PageDown, ScrollUp, ScrollDown should not be added to the jumplist. #29431
• j and k (e.g. 15j)
• Clicking somewhere in the editor