Skip to content

Don't push to nav history when scrolling #17592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
alex35mil opened this issue Sep 9, 2024 · 6 comments · May be fixed by #30345
Open
1 task done

Don't push to nav history when scrolling #17592

alex35mil opened this issue Sep 9, 2024 · 6 comments · May be fixed by #30345
Labels
editor Feedback for code editing, formatting, editor iterations, etc feature [core label] setting Feedback for preferences, configuration, etc vim

Comments

@alex35mil
Copy link

Check for existing issues

  • Completed

Describe the feature

Option to control either jumps made via vim::ScrollUp/Down are included in the jumplist.

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@ConradIrwin
Copy link
Member

What is the default behavior of vim here? Currently our jumpiest copies Zed's but I'd like to make it more useful.

@Moshyfawn Moshyfawn added vim editor Feedback for code editing, formatting, editor iterations, etc and removed triage labels Sep 13, 2024
@alex35mil
Copy link
Author

I don't remember the default behavior, but in Vim there is keepjumps to skip adding entries to the jumplist.

@JosephTLyons JosephTLyons added setting Feedback for preferences, configuration, etc and removed admin read labels Sep 17, 2024
@ChristianChiarulli
Copy link

The current implementation in zed seems to pollute the jumplist with every scroll up/down. The implementation in vim/neovim seems to ignore adding scrolling up and down to the jumplist with commands like ctrl-u, ctrl-d, ctrl-f, ctrl-b. Even if it didn't I would like to have the ability to ignore these since often i will do something like:

gd press ctrl-d a few times to scroll and then press ctrl-o to go back to before gd if that makes sense.

@ConradIrwin ConradIrwin changed the title Add option to control either jumps made via vim::ScrollUp/Down are included in the jumplist Don't push to nav history when scrolling Mar 22, 2025
@ConradIrwin
Copy link
Member

I think we can fix this by adding a flag to the editor to say "don't push to nav history" when we scroll. If anyone wants to pair with me on this: https://cal.com/conradirwin/pairing

@ChristianChiarulli
Copy link

Any update on this? It's kinda the only thing holding me back from using zed more often.

@janko
Copy link

janko commented May 19, 2025

What is the default behavior of vim here? Currently our jumpiest copies Zed's but I'd like to make it more useful.

Stock Vim 9.1 (no plugins) doesn't update the jump list when scrolling up/down ctrl-u/ctrl-d. Zed recording these as jumps makes traversing the jump list with ctrl-o/ctrl-i much less useful for me.

Fixing this would probably make Zed fully compatible with my previous Vim workflow 🤞🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Feedback for code editing, formatting, editor iterations, etc feature [core label] setting Feedback for preferences, configuration, etc vim
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants