Skip to content

Conversation

@gsabran
Copy link
Contributor

@gsabran gsabran commented Oct 25, 2025

This change will allow for this package to be used directly, without launching a subprocess and communicating over stdio.

@cla-bot
Copy link

cla-bot bot commented Oct 25, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @gsabran on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@gsabran
Copy link
Contributor Author

gsabran commented Oct 25, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Oct 25, 2025
@cla-bot
Copy link

cla-bot bot commented Oct 25, 2025

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Member

@benbrandt benbrandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thanks for doing this!

@benbrandt benbrandt enabled auto-merge (squash) October 27, 2025 11:10
@benbrandt benbrandt merged commit 5491bb8 into zed-industries:main Oct 27, 2025
2 checks passed
@benbrandt
Copy link
Member

benbrandt commented Oct 27, 2025

@gsabran there were some cases (Zed included) that were relying on this old entrypoint. #127

I reverted and move the library entrypoint to a new file. Let me know if v0.8.0 works for you

@gsabran
Copy link
Contributor Author

gsabran commented Oct 27, 2025

I'll test it, but that should work. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants