Skip to content

fix, feat: use static string for Vue LSP version & add a GitHub Action to auto detect new version #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cuongvuong-phoenix
Copy link

As mentioned in #23, I think it's best to have a static version embedded into each version of the extension to:

  • Prevent possible breaking changes in the future.
  • Allow users to choose a specific version of Zed's Vue extension corresponding to a Vue LSP version.
  • Avoid abusing NPM/GitHub APIs because every time a user opens Zed, the extension will send a request to get the latest version and check against the local version.
    I recently encountered an issue with the "Snippets" extension and got errors due to GitHub API rate limit...

In this PR, I also added a GitHub Action to help update to the latest version of Vue LSP every 12 hours and automatically create a PR that bumps both the static version string and Cargo.toml. The workflow runs quite fast (10-15s), you can check the result in my forked repo.

This comment was marked as resolved.

@cuongvuong-phoenix

This comment was marked as resolved.

@cla-bot cla-bot bot added the cla-signed label Mar 17, 2025

This comment was marked as resolved.

Copy link

@ThatOneCalculator ThatOneCalculator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants