Add debug test tasks #44
Conversation
rxptr
left a comment
rxptr
left a comment
There was a problem hiding this comment.
Thanks for the PR, it looks good, only a tiny change.
src/odin.rs
Outdated
| // Add a special prefix to clarify debugging tests | ||
| let label = if is_test { | ||
| format!("debug test: {}", base_label) | ||
| } else { | ||
| base_label | ||
| }; |
There was a problem hiding this comment.
I believe this is redundant; in the debug modal, every task is a debug task. But specifically it makes the run button in the gutter look awkward:
There was a problem hiding this comment.
Yeah good point, thanks for noticing that. I didn't realize the same task would show up in the gutter as well.
By just reverting these few changes I think it looks pretty good leaving that "test: " prefix on it.
src/odin.rs
Outdated
| let label = resolved_label | ||
| .clone() | ||
| .strip_prefix("run: ") | ||
| .or_else(|| resolved_label.strip_prefix("test: ")) |
There was a problem hiding this comment.
Having this line was fine, it makes the gutter more clean. Now we have debug: test: 'Test name'
There was a problem hiding this comment.
The problem I found with this is that by removing the test: prefix it also removes it from the label in the F4 Debug menu making it unclear the task is for debugging tests
There was a problem hiding this comment.
Fair enough, let's just drop the colon (": ") then.
2 participants
This PR enhances the existing Odin Zed extension to support debugging tests so you can catch breakpoints in tests with ease.
In most cases this creates two new debug tasks:
#2above also shows in the gutter next to the individual test functions as well.Example: