Skip to content

Conversation

@zakuciael
Copy link
Contributor

Updates the zed_extension_api crate to 0.7.0 and subsequently fixes #38

Closes #38

@cla-bot cla-bot bot added the cla-signed label Jan 3, 2026
@MrSubidubi
Copy link
Contributor

Thanks for this! Could you elaborate how this fixes this? I think we'd still need the settings support to be implemented, at least prior to zed-industries/zed#44398 landing

@zakuciael
Copy link
Contributor Author

Thanks for this! Could you elaborate how this fixes this? I think we'd still need the settings support to be implemented, at least prior to zed-industries/zed#44398 landing

For clarity: this PR does not remove the extension's need to call the
LspSettings::for_worktree(...) method.

While debugging, I discovered that for_worktree method was always returning None
unless the settings were present in the global settings.json file. I then found
this cherry-picked PR: zed-industries/zed/#10861, which describes the same
problem. After upgrading the extension_api to the latest version, the issue was resolved.

@MrSubidubi
Copy link
Contributor

Nice digging and thank you for the context!

I totally missed that this was already implemented for this extension, hence my confusion here, sorry for that! But that indeed looks like a proper fix then, thank you very much!

Could you please merge main here? I fixed the CI failures on main (we rolled out some changes to the org, that's why you ran into these) and then we are good to go!

Copy link
Contributor

@MrSubidubi MrSubidubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, appreciate it!

@MrSubidubi MrSubidubi merged commit e98c85f into zed-extensions:main Jan 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Options setting only works in the global settings

2 participants