fix: resolve asdf and SDKMAN Java shims to actual installation paths #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Detect when JAVA_HOME or java executable points to asdf shims directory - Use 'asdf which java' to resolve shims to actual Java installation - Add support for SDKMAN Java installations - Properly infer JAVA_HOME from resolved paths - Fixes services failing with "JAVA_HOME not defined correctly" when using asdf This resolves the issue where Vertex inherited JAVA_HOME pointing to /.asdf/shims instead of the actual Java installation path like /.asdf/installs/java/openjdk-21, causing Maven and Gradle wrappers to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue where Vertex inherited JAVA_HOME pointing to /.asdf/shims instead of the actual Java installation path like /.asdf/installs/java/openjdk-21, causing Maven and Gradle wrappers to fail.