fix: resolve nginx first-run installation failures #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced path detection for Apple Silicon vs Intel homebrew installations - Added comprehensive log file permission handling with proper ownership - Implemented PID file cleanup to prevent root-owned file conflicts - Added pre-start PID file validation and removal in service startup - Improved nginx service start verification with status checking - Fixed cross-platform directory and file permission management Resolves issue where nginx installation would fail on first run due to permission conflicts with log files and PID files created by previous root processes. Installation now succeeds reliably on first attempt.
- Remove platform-specific syscall import that fails on Linux CI/CD - Replace syscall.Stat_t usage with portable 'ls -la' command parsing - Maintain same functionality for detecting root-owned PID files - Ensures compatibility across macOS, Linux, and CI/CD environments Resolves build failures in CI/CD pipelines while preserving the nginx permission fix functionality for first-run installations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue where nginx installation would fail on first run due to permission conflicts with log files and PID files created by previous root processes. Installation now succeeds reliably on first attempt.