Fix crashes in ZBCommand
#2092
Open
Fix crashes in ZBCommand
#2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kirb Might be worth pulling these new types out into a new file, what do you think? |
kirb
requested changes
Jul 1, 2025
Replace manual pipe allocation and tedious/unsafe opening/closing of pipes with safe objc wrappers that handle the sanity checks at each step. Safer and less boilerplate
NSExceptional
force-pushed
the
tb/v1/fix-zbcommand-bugs
branch
from
e5a341c to
0d280a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace manual pipe allocation and tedious/unsafe opening/closing of pipes with safe objc wrappers that handle the sanity checks at each step. Safer and less boilerplate