Parametrize Array with v2/v3 metadata #3304
Open
+208
−222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
d-v-b
reviewed
Jul 28, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3304 +/- ##
==========================================
+ Coverage 60.73% 60.79% +0.06%
==========================================
Files 78 79 +1
Lines 9407 9423 +16
==========================================
+ Hits 5713 5729 +16
Misses 3694 3694
🚀 New features to boost your workflow:
|
dstansby
force-pushed
the
array-param
branch
3 times, most recently
from
53da48a to
d9e50d2
Compare
github-actions
bot
removed
the
needs release notes
d-v-b
reviewed
Jul 28, 2025
| AsyncArrayV3: TypeAlias = AsyncArray[ArrayV3Metadata] | ||
| """A Zarr format 3 `AsyncArray`""" | ||
|
|
||
| AnyArray: TypeAlias = Array[Any] |
There was a problem hiding this comment.
Should this be Array[ArrayV2Metadata] | Array[ArrayV3Metadata]
There was a problem hiding this comment.
Yep, I guess that's safer 👍
There was a problem hiding this comment.
I couldn't get that to work, beacuse of an error that I sort of but not really understand Any is fine though - .metadata still gets inferred correctly:
import zarr
import zarr.storage
arr = zarr.ones(shape=(1,))
meta = arr.metadata
reveal_locals()
"""
test.py:6: note: Revealed local types are:
test.py:6: note: arr: zarr.core.array.Array[Any]
test.py:6: note: meta: zarr.core.metadata.v2.ArrayV2Metadata | zarr.core.metadata.v3.ArrayV3Metadata
"""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been a longstanding bugbear of mine that there's no easy way to specify a v2 or v3 array type. This especially came up in the context of #3257, which deals specifically with v2/v3 arrays.
This PR ads type parametrization to the
Arrayclass.After this PR, there is lots of improvements to adding overloads to functions and methods that could be made, but to keep review easier I'd like to leave that for a follow up PR.