Skip to content

Add missing import for AsyncFileSystemWrapper for _make_async in _fsspec.py #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2025
Merged

Add missing import for AsyncFileSystemWrapper for _make_async in _fsspec.py #3195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9598797
Add missing import for AsyncFileSystemWrapper in `_fsspec.py`
Jul 2, 2025
d9f7aef
Add missing changelog entry for AsyncFileSystemWrapper import fix
Jul 2, 2025
965f962
Move AsyncFileSystemWrapper import past the version check in `_fsspec…
Jul 2, 2025
e0999b2
Add newline after AsyncFileSystemWrapper import in `_fsspec.py`
Jul 2, 2025
a3b97ac
Simplify import statement for AsyncFileSystemWrapper in `_fsspec.py`
Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/3195.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add missing import for AsyncFileSystemWrapper for _make_async in _fsspec.py
4 changes: 3 additions & 1 deletion src/zarr/storage/_fsspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@
"2024.12.0 or later to enable this functionality."
)

return fsspec.implementations.asyn_wrapper.AsyncFileSystemWrapper(fs, asynchronous=True)
from fsspec.implementations.asyn_wrapper import AsyncFileSystemWrapper

Check warning on line 71 in src/zarr/storage/_fsspec.py

View check run for this annotation

Codecov / codecov/patch

src/zarr/storage/_fsspec.py#L71 

Added line #L71 was not covered by tests

return AsyncFileSystemWrapper(fs, asynchronous=True)

Check warning on line 73 in src/zarr/storage/_fsspec.py

View check run for this annotation

Codecov / codecov/patch

src/zarr/storage/_fsspec.py#L73 

Added line #L73 was not covered by tests


class FsspecStore(Store):
Expand Down