Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(volar): prevent semantic server crushes in new versions #194

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

Ilanaya
Copy link
Collaborator

@Ilanaya Ilanaya commented Jan 29, 2024

Resolves #191

Ofc this issue is reproducible with local build too. I didn't find out why this exceptions is thrown, but I think replacing throw with console.error should be good.

@zardoy
Copy link
Owner

zardoy commented Jan 29, 2024

Yes it's good but I wonder how you couldn't find an error that was thrown. So completions won't work if there is an error which is also not good (probably there is a configuration error or Vue TS plugins started to cause some other error?)

@zardoy zardoy changed the title fix(vue integration): prevent semantic server crushes fix(volar): prevent semantic server crushes in new versions Jan 29, 2024
@zardoy zardoy merged commit 9a2afd9 into develop Jan 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue semantic server connection drops
2 participants