Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refactoring): add/from destructure bug fixes, this keyword support #183

Merged
merged 16 commits into from
Nov 15, 2023

Conversation

Ilanaya
Copy link
Collaborator

@Ilanaya Ilanaya commented Nov 12, 2023

Closes #167

      function deleteConferenceListEndHandler(deletedConferenceIds) {
        deletedConferenceIds.forEach((deletedConferenceId) => {
          this.conferenceDeletedHandler(deletedConferenceId);
        });
      },

@Ilanaya
Copy link
Collaborator Author

Ilanaya commented Nov 13, 2023

@zardoy Can you please help to reproduce the issue with highlights in type nodes? I somehow forgot the case :(

Obviously we shouldn't display code action at all in cases like this (with typeof):

const obj = {
  test: 1,
}
obj.test

type foo = typeof obj

I'm trying different variations of this code but it works fine...

type obj = {
  foo: 1,
  obj: 3
}

const test = /** @type {obj} */('asdf')

const obj = {
  test: 1,
}
obj.test

@zardoy
Copy link
Owner

zardoy commented Nov 15, 2023

@Ilanaya
This one:

/**
 * 
 * @param a 
 */
const a = (a) => {
    a // here
}

@Ilanaya
Copy link
Collaborator Author

Ilanaya commented Nov 15, 2023

@Ilanaya This one:

/**
 * 
 * @param a 
 */
const a = (a) => {
    a // here
}

@zardoy I can't reproduce with this code and its variations; I may have added stricter checks somewhere. By the way, can we install prettier as dev dep in the project? I always get conflicts with the ci's npx prettier as it uses prettier v3.1 when vscode's extension currently works with v2 by default

@zardoy
Copy link
Owner

zardoy commented Nov 15, 2023

I can't reproduce with this code and its variations; I may have added stricter checks somewhere.

ok, feel free to merge.

And what about prettier the answer is yes, i thought prettier was already installed so feel free to do it since npx prefers local packages. btw didn't know they downgraded prettier in the extension

@Ilanaya
Copy link
Collaborator Author

Ilanaya commented Nov 15, 2023

Merging now. Vue support needs more effort than I expected.

Can we, please, release it ASAP? This code action version is much more stable than in the current release.

@Ilanaya Ilanaya changed the title feat(refactoring): add/from destructure improvements feat(refactoring): add/from destructure bug fixes, this keyword support Nov 15, 2023
@Ilanaya Ilanaya merged commit 0b1c13f into develop Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to destruct, from destruct
2 participants