-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(refactoring): add/from destructure bug fixes, this
keyword support
#183
Conversation
@zardoy Can you please help to reproduce the issue with highlights in type nodes? I somehow forgot the case :( Obviously we shouldn't display code action at all in cases like this (with const obj = {
test: 1,
}
obj.test
type foo = typeof obj I'm trying different variations of this code but it works fine... type obj = {
foo: 1,
obj: 3
}
const test = /** @type {obj} */('asdf')
const obj = {
test: 1,
}
obj.test |
@Ilanaya /**
*
* @param a
*/
const a = (a) => {
a // here
} |
@zardoy I can't reproduce with this code and its variations; I may have added stricter checks somewhere. By the way, can we install |
ok, feel free to merge. And what about prettier the answer is yes, i thought prettier was already installed so feel free to do it since npx prefers local packages. btw didn't know they downgraded prettier in the extension |
Merging now. Vue support needs more effort than I expected. Can we, please, release it ASAP? This code action version is much more stable than in the current release. |
this
keyword support
Closes #167