Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextgen physics #257

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Nextgen physics #257

wants to merge 2 commits into from

Conversation

zardoy
Copy link
Owner

@zardoy zardoy commented Jan 29, 2025

PR Type

enhancement, configuration changes


Description

  • Updated mineflayer dependency to use a local file reference.

  • Updated @nxg-org/mineflayer-physics-util dependency to use a local file reference.

  • Adjusted package.json to reflect dependency changes for local development.


Changes walkthrough 📝

Relevant files
Configuration changes
package.json
Updated dependencies to local file references                       

package.json

  • Changed mineflayer dependency to a local file reference.
  • Changed @nxg-org/mineflayer-physics-util dependency to a local file
    reference.
  • Adjusted dependency paths for local development purposes.
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    codesandbox bot commented Jan 29, 2025

    Review or Edit in CodeSandbox

    Open the branch in Web EditorVS CodeInsiders

    Open Preview

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Dependency Path

    The local file paths for mineflayer and physics-util dependencies may not work in all environments. Ensure the relative paths are correct and the referenced local packages exist.

      "mineflayer": "file:../mineflayer",
      "mineflayer-pathfinder": "^2.4.4",
      "npm-run-all": "^4.1.5",
      "os-browserify": "^0.3.0",
      "path-browserify": "^1.0.1",
      "path-exists-cli": "^2.0.0",
      "prismarine-viewer": "link:prismarine-viewer",
      "process": "github:PrismarineJS/node-process",
      "rimraf": "^5.0.1",
      "storybook": "^7.4.6",
      "stream-browserify": "^3.0.0",
      "three": "0.154.0",
      "timers-browserify": "^2.0.12",
      "typescript": "5.5.4",
      "vitest": "^0.34.6",
      "yaml": "^2.3.2"
    },
    "optionalDependencies": {
      "cypress": "^10.11.0",
      "cypress-plugin-snapshots": "^1.4.4",
      "systeminformation": "^5.21.22"
    },
    "pnpm": {
      "overrides": {
        "buffer": "^6.0.3",
        "@nxg-org/mineflayer-physics-util": "file:../mineflayer-physics-utils",

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Use versioned dependencies instead of local

    Using local file dependencies without version control can lead to inconsistent
    builds. Consider using git URLs with specific commits/tags instead of local file
    paths.

    package.json [148-173]

    -"mineflayer": "file:../mineflayer",
    -"@nxg-org/mineflayer-physics-util": "file:../mineflayer-physics-utils",
    +"mineflayer": "github:username/mineflayer#commit-hash",
    +"@nxg-org/mineflayer-physics-util": "github:username/mineflayer-physics-utils#commit-hash",
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Using local file dependencies can lead to build inconsistencies and makes it harder to track dependency versions. The suggestion to use git URLs with specific commit hashes would improve reproducibility and version control.

    7

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant