-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: item & maps in frame rendering #243
base: next
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Wow, I'm kind of impressed. Very cool, seems you understand the code base very well :) Will make sure to answer your questions in a few days |
transparent: true, | ||
alphaTest: 0.1 | ||
}) | ||
loadTexture(imageData, texture => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will texture be removed when the map entity is removed? from the current code it doesn't seem so, would be great if you could test:
- in console type:
viewer.renderer.info.memory.textures
- this number should not increase after removing / re-adding, thanks
266eb20
to
3db17c5
Compare
3db17c5
to
b3d932f
Compare
…m models This includes disposing of remove item/map meshes of item frames
This is my WIP of rendering of item frames and especially maps in them. Opening this as a draft PR just to show my current state as a I wont be able to work on this for the next two weeks due to the holidays.
What works:
What doesn't work: