remove duplicated plugin load

zardoy · Jan 16, 2025 · 0fc37a5 · 0fc37a5
1 parent 1ee70a8
commit 0fc37a5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/prismarine-viewer/viewer/lib/entities.ts b/prismarine-viewer/viewer/lib/entities.ts
@@ -755,14 +755,14 @@ export class Entities extends EventEmitter {
     }
   }
 
-  updateMap (mapNumber, data) {
+  updateMap (mapNumber: string | number, data: string) {
     this.cachedMapsImages[mapNumber] = data
-    let itemFrameMeshs = this.itemFrameMaps[mapNumber]
-    if (!itemFrameMeshs) return
-    itemFrameMeshs = itemFrameMeshs.filter(mesh => mesh.parent)
-    this.itemFrameMaps[mapNumber] = itemFrameMeshs
-    if (itemFrameMeshs) {
-      for (const mesh of itemFrameMeshs) {
+    let itemFrameMeshes = this.itemFrameMaps[mapNumber]
+    if (!itemFrameMeshes) return
+    itemFrameMeshes = itemFrameMeshes.filter(mesh => mesh.parent)
+    this.itemFrameMaps[mapNumber] = itemFrameMeshes
+    if (itemFrameMeshes) {
+      for (const mesh of itemFrameMeshes) {
         mesh.material.map = this.loadMap(data)
         mesh.material.needsUpdate = true
         mesh.visible = true

diff --git a/src/react/HeldMapUi.tsx b/src/react/HeldMapUi.tsx
@@ -6,8 +6,6 @@ export default () => {
   const [dataUrl, setDataUrl] = useState<string | null | true>(null) // true means loading
 
   useEffect(() => {
-    bot.loadPlugin(mapDownloader)
-
     setImageConverter((buf: Uint8Array) => {
       const canvas = document.createElement('canvas')
       const ctx = canvas.getContext('2d')!