authhelper: support single-input TOTP fields and improve field interaction#7259
Open
sarathivengadesh wants to merge 1 commit intozaproxy:mainfrom
Open
authhelper: support single-input TOTP fields and improve field interaction#7259sarathivengadesh wants to merge 1 commit intozaproxy:mainfrom
sarathivengadesh wants to merge 1 commit intozaproxy:mainfrom
Conversation
…nteraction - Add TOTP_FIELD support for single combined input (e.g. GitHub, Codeberg style) in addition to existing per-character input boxes - Replace fillField with fillFieldWithEvents to trigger JS events so React/Angular apps register typed values correctly - Add precomputedTotpCode overload to avoid clock skew across multiple steps - Fix MsLoginAuthenticator to use updated DefaultAuthenticator signature Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
Member
|
New Issues (158)Checkmarx found the following issues in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
thc202
changed the title
Author
|
I have read the CLA Document and I hereby sign the CLA |
Member
|
This needs tests. |
Member
|
Also examples where the current sendKeys fails, that sounds more like a bug in the WebDriver spec since they are supposed to behave like user input. |
thc202
reviewed
Apr 7, 2026
Comment on lines
-365
to
+366
| proofTotpElement.clear(); | ||
| proofTotpElement.sendKeys(TotpSupport.getCode(credentials)); | ||
| CharSequence totpCode = TotpSupport.getCode(credentials); | ||
| AuthUtils.fillFieldWithEvents(proofTotpElement, totpCode.toString(), wd); |
Member
There was a problem hiding this comment.
This should be reverted, this existing code is working correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Changes: