ascanrulesBeta: Add getExampleAlerts to Username Enumeration rule#7249
Open
Karl-Seryani wants to merge 7 commits intozaproxy:mainfrom
Open
ascanrulesBeta: Add getExampleAlerts to Username Enumeration rule#7249Karl-Seryani wants to merge 7 commits intozaproxy:mainfrom
Karl-Seryani wants to merge 7 commits intozaproxy:mainfrom
Conversation
Member
|
New Issues (158)Checkmarx found the following issues in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
thc202
reviewed
Apr 1, 2026
...Beta/src/main/java/org/zaproxy/zap/extension/ascanrulesBeta/UsernameEnumerationScanRule.java
Outdated
Show resolved
Hide resolved
3 tasks
Contributor
Author
|
Done, moved the i18n calls into buildAlert() so the keys only exist in one place now. |
kingthorin
reviewed
Apr 1, 2026
Karl-Seryani
commented
Apr 1, 2026
Contributor
Author
Karl-Seryani
left a comment
Karl-Seryani
left a comment
There was a problem hiding this comment.
Yep, ran the full test suite and check for ascanrulesBeta, everything passes. No compile issues or signature mismatches.
kingthorin
reviewed
Apr 1, 2026
...Beta/src/main/java/org/zaproxy/zap/extension/ascanrulesBeta/UsernameEnumerationScanRule.java
Outdated
Show resolved
Hide resolved
...Beta/src/main/java/org/zaproxy/zap/extension/ascanrulesBeta/UsernameEnumerationScanRule.java
Outdated
Show resolved
Hide resolved
...Beta/src/main/java/org/zaproxy/zap/extension/ascanrulesBeta/UsernameEnumerationScanRule.java
Outdated
Show resolved
Hide resolved
kingthorin
approved these changes
Apr 6, 2026
thc202
reviewed
Apr 6, 2026
...Beta/src/main/java/org/zaproxy/zap/extension/ascanrulesBeta/UsernameEnumerationScanRule.java
Show resolved
Hide resolved
...Beta/src/main/java/org/zaproxy/zap/extension/ascanrulesBeta/UsernameEnumerationScanRule.java
Outdated
Show resolved
Hide resolved
...Beta/src/main/java/org/zaproxy/zap/extension/ascanrulesBeta/UsernameEnumerationScanRule.java
Outdated
Show resolved
Hide resolved
...Beta/src/main/java/org/zaproxy/zap/extension/ascanrulesBeta/UsernameEnumerationScanRule.java
Outdated
Show resolved
Hide resolved
Member
|
There's a conflict in the changelog. |
Add getExampleAlerts() to UsernameEnumerationScanRule for documentation generation (Issue 6119). Extracts alert building into a reusable helper method using existing i18n keys. Signed-off-by: Karl Seryani <karlseryani@gmail.com>
Signed-off-by: Karl Seryani <karlseryani@gmail.com>
Signed-off-by: Karl Seryani <karlseryani@gmail.com>
Signed-off-by: Karl Seryani <karlseryani@gmail.com>
…le delta Signed-off-by: Karl Seryani <karlseryani@gmail.com>
Signed-off-by: Karl Seryani <karlseryani@gmail.com>
Karl-Seryani
force-pushed
the
feat/6119-username-enum-example-alerts
branch
from
621a247 to
42b8d7b
Compare
kingthorin
reviewed
Apr 7, 2026
Comment on lines
+730
to
+734
| if (delta.getType() == Delta.TYPE.CHANGE) changeType = "Changed Text"; | ||
| else if (delta.getType() == Delta.TYPE.DELETE) changeType = "Deleted Text"; | ||
| else if (delta.getType() == Delta.TYPE.INSERT) changeType = "Inserted text"; | ||
| else changeType = "Unknown change type [" + delta.getType() + "]"; | ||
|
|
Member
There was a problem hiding this comment.
I know this is syntactically correct but using braces for consistency/readability would be best.
This whole loop and the text it's building should all be internationalized (ex: Use the message.properties key/values/substitution)
Contributor
Author
There was a problem hiding this comment.
Done, added braces and moved all the diff text into Messages.properties keys.
Member
There was a problem hiding this comment.
For the record this was existing code.
Member
There was a problem hiding this comment.
Okay, that's on me.
@thc202 are you okay with it going forward this way?
Signed-off-by: Karl Seryani <karlseryani@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds
getExampleAlerts()toUsernameEnumerationScanRulefor documentation generation purposes.Changes
buildAlert()helper methodgetExampleAlerts()returning an example alert using existing i18n keys andHtmlParameter.Type.formconstantshouldHaveExpectedExampleAlerts()Related Issues
Contributes to zaproxy/zaproxy#6119
Test Plan
./gradlew :addOns:ascanrulesBeta:checkpassesshouldHaveExpectedExampleAlertspasses