-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix(coprocessor): host-listener, dependency chain #1519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: georgi/tfhe-worker/dependence_chain_id
Are you sure you want to change the base?
fix(coprocessor): host-listener, dependency chain #1519
Conversation
| for (age, log) in logs.iter().enumerate() { | ||
| let tx = log.transaction_hash.unwrap_or_default(); | ||
| if let Some(handle) = tfhe_result_handle(&log.event) { | ||
| handle_to_tx.insert(handle, (age, tx)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's possible, but ideally this should be filtered to only include allowed handles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is filtered for the past cache, but still needed here to detect internal dependency. Otherwise it could promote an old handle (several block before) as dependency chain vs the fresher one. But this policy could be changed if you think it's better the other way around for transaction internal dependency.r
…iple workers It provides a non-blocking, distributed locking mechanism that coordinates dependence-chain processing across multiple tfhe-workers. A worker can acquire ownership of the next available dependence-chain entry for processing ordered by last_updated_at (FIFO queue-like approach). Ownership expires after a timeout, enabling work-stealing by other workers. New CLI param --worker_id
- Added LockingReason for logging - Make expiry configurable
111dc67 to
cf81b98
Compare
cf81b98 to
5b28a38
Compare
5b28a38 to
5298c04
Compare
5298c04 to
d7da475
Compare
4618e0d to
b206f87
Compare
d7da475 to
f3b7192
Compare
Compute chain dependency on the transaction level instead of ops level.