otel/xxray: add custom X-Ray propagator that preserves X-Amzn-Trace-Id #3668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
otel/xxray
branch
from
acbfcd1 to
4aa96a6
Compare
AlexanderYastrebov
added
major
AlexanderYastrebov
force-pushed
the
otel/xxray
branch
from
4aa96a6 to
ab2dd9b
Compare
otel/otel.go
Outdated
| } | ||
|
|
||
| func init() { | ||
| autoprop.RegisterTextMapPropagator("xxray", xxray.NewPropagatorGenerator()) |
There was a problem hiding this comment.
We can also add a config field e.g .PropagatorXRayReuseTraceID instead of a new name and create custom implementation if it is set.
AlexanderYastrebov
force-pushed
the
otel/xxray
branch
from
ab2dd9b to
003b1dc
Compare
Updates #3663 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
otel/xxray
branch
from
003b1dc to
2c39823
Compare
| } | ||
| value := part[equalsIndex+1:] | ||
| switch { | ||
| case strings.HasPrefix(part, traceIDKey): |
There was a problem hiding this comment.
This is ugly and also allows RootFooBar=123 key 🤷 . Parsing should be done via strings.Cut or similar to #3405
|
maybe we can add these samples in the test: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-request-tracing.html |
szuecs
reviewed
Oct 16, 2025
| @@ -0,0 +1,159 @@ | |||
| package xxray | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #3663