Enable native OPA Prometheus metrics #3631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjungsbluth
added
the
major
szuecs
reviewed
Sep 23, 2025
szuecs
reviewed
Sep 23, 2025
szuecs
reviewed
Sep 23, 2025
Member
|
👍 |
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
Signed-off-by: Magnus Jungsbluth <[email protected]>
mjungsbluth
force-pushed
the
opa_prometheus_metrics
branch
from
b312fc6 to
e5f79ef
Compare
Collaborator
Author
|
@torwunder could you also have a look? |
torwunder
reviewed
Oct 15, 2025
|
|
||
| found := false | ||
| for _, mf := range metricsFamilies { | ||
| if mf.GetName() == "plugin_status_gauge" && len(mf.Metric) > 0 { |
Contributor
There was a problem hiding this comment.
you could also verify the labels for the metrics as this is also part of the interface to the outside
szuecs
reviewed
Oct 24, 2025
|
|
||
| func (p *Prometheus) Close() {} | ||
|
|
||
| // Implements the PrometheusMetrics interface |
Member
There was a problem hiding this comment.
Godoc should start by the func name
| } | ||
|
|
||
| opaRegistry, err = openpolicyagent.NewOpenPolicyAgentRegistry( | ||
| registryOpts := []func(*openpolicyagent.OpenPolicyAgentRegistry) error{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes through existing Prometheus metrics from Open Policy Agent by prefixing them to fit with remainging Skipper metrics and labeling them per virtual OPA instance.
This can only be supported for the Prometheus metrics flavour and is breaking the metrics abstraction as it pulls the Prometheus
Registererto the outside but avoids maintaining and copying existing work that has happened upstream in Open Policy Agent.Should only be merged after #3562 is merged