tracing/tracingtest: deprecate Tracer and Span types #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-66
to
-74
| if len(tracer.RecordedSpans) == 0 { | ||
| t.Fatal("no span recorded...") | ||
| } | ||
| if tracer.RecordedSpans[0].Trace != traceContent { | ||
| t.Errorf("trace not found, got `%s` instead", tracer.RecordedSpans[0].Trace) | ||
| } | ||
| if len(tracer.RecordedSpans[0].Refs) == 0 { | ||
| t.Errorf("no references found, this is a root span") | ||
| } |
There was a problem hiding this comment.
This tested tracer internals and not HTTP propagator or something.
AlexanderYastrebov
added
the
major
AlexanderYastrebov
force-pushed
the
tracing/tracingtest/deprecate-tracer
branch
5 times, most recently
from
f459e69 to
bc966f4
Compare
AlexanderYastrebov
force-pushed
the
tracing/tracingtest/deprecate-tracer
branch
from
bc966f4 to
e9c9be7
Compare
AlexanderYastrebov
added
minor
|
|
||
| testCases := []struct { | ||
| name string | ||
| req *http.Request | ||
| tracer opentracing.Tracer | ||
| parentSpan opentracing.Span | ||
| parentSpan string |
There was a problem hiding this comment.
This change is because closing parent span created during test case setup after tracer.Reset() is wrong and does not work properly with MockTracer.
AlexanderYastrebov
force-pushed
the
tracing/tracingtest/deprecate-tracer
branch
from
e9c9be7 to
d86c1c8
Compare
Follow up on #684 (#684 (comment)) and deprecate hand-rolled test tracer implementation in favour of MockTracer added by #3322 that wraps github.com/opentracing/opentracing-go/mocktracer and waits for finished spans. Fix MockTracer: * return MockSpan that has proper Tracer() implementation * return MockSpan wrappers from FinishedSpans * panic on timeout waiting for finished spans Closes #2084 Updates #2104 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
tracing/tracingtest/deprecate-tracer
branch
from
d86c1c8 to
331f035
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #684 (#684 (comment)) and
deprecate hand-rolled test tracer implementation in favour of
MockTracer added by #3322 that wraps github.com/opentracing/opentracing-go/mocktracer and waits for finished spans.
Fix MockTracer:
Closes #2084
Updates #2104