use upgraded instance types in default-for-karpenter #8690
Merged
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demonCoder95
added
the
minor
|
👍 |
quick review of the table in the description; similar to my comment on the e2e PR, I think there was a typo on the m5 replacement and there's no c6 changes in this PR. Is that correct? |
|
I fixed the typo, thanks for highlighting it 🙂 Yes, that's correct. I copied the table from the internal issue we have for the replacement strategy, I copied the typo over 🙈 I fixed it now. |
|
The PR looks ok, but the description also mentions c6g/c7g which should not (and is not) included. Those should not be included as there would be the risk of spinning up an ARM node for pods with a container image only working on amd64. I crossed those out in the description. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to perform instance type upgrades:
c6gc7gFor the
default-for-karpentertype, we can simply drop the older types as we already have the new ones in the list.c6gis not in the list so no replacement is needed.