fix: replace hardcoded .cuda() with dynamic device selection#553
Open
Mr-Neutr0n wants to merge 1 commit intozai-org:mainfrom
Open
fix: replace hardcoded .cuda() with dynamic device selection#553Mr-Neutr0n wants to merge 1 commit intozai-org:mainfrom
Mr-Neutr0n wants to merge 1 commit intozai-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The demo scripts
basic_demo/cli_demo_sat.pyandbasic_demo/web_demo.pyhardcode.cuda()calls anddevice='cuda', which causes failures on non-CUDA systems (e.g., Apple Silicon with MPS, or CPU-only machines).Fix
_get_device()helper that detects the best available device (CUDA > MPS > CPU).device='cuda'withdevice=_get_device()in model loading.model.cuda()withmodel.to(device)in quantization blocks.torch.cuda.is_available()todevice != 'cpu'so MPS users also benefit from GPU acceleration when quantization is enabled.