Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty CTCP ACTION sending two literal underscores on Discord #1

Closed
wants to merge 1 commit into from
Closed

Fix empty CTCP ACTION sending two literal underscores on Discord #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions bridge/irc_listener.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,14 @@ func (i *ircListener) OnPrivateMessage(e *irc.Event) {
replacements...,
).Replace(e.Message())

if e.Code == "CTCP_ACTION" {

// Italicize the /me action so it appears like Discord's /me functionality.
// We don't do it for empty messages, since Discord will show two literal underscores.
// Sending empty messages onto the discordMessagesChan is fine, since the sender will
// take care of inserting ZWBs if necessary.
if e.Code == "CTCP_ACTION" && msg != "" {
msg = "_" + msg + "_"
}

msg = ircf.BlocksToMarkdown(ircf.Parse(msg))

go func(e *irc.Event) {
Expand Down
Loading