fix: detect entry script under pm2 in isMain check#36
Open
unggun wants to merge 1 commit into
Open
Conversation
The upstream isMain check (added in 99fb060) compared path.resolve(process.argv[1]) against fileURLToPath(import.meta.url). Under pm2, process.argv[1] is pm2's ProcessContainerFork.js wrapper, not the user's script — so isMain was always false and ALL startup code (cron registration, telegram polling, hivemind bootstrap) was silently skipped. Process appeared "online" but produced zero log output and ran no work. Fix: also accept process.env.pm_exec_path, which pm2 sets to the user's actual entry script path. Direct `node index.js` invocation keeps working via the original argv check. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream isMain check (added in 99fb060) compared path.resolve(process.argv[1]) against fileURLToPath(import.meta.url). Under pm2, process.argv[1] is pm2's ProcessContainerFork.js wrapper, not the user's script — so isMain was always false and ALL startup code (cron registration, telegram polling, hivemind bootstrap) was silently skipped. Process appeared "online" but produced zero log output and ran no work.
Fix: also accept process.env.pm_exec_path, which pm2 sets to the user's actual entry script path. Direct
node index.jsinvocation keeps working via the original argv check.