Cache git logs to accelerate displaying the versions of a node in oxidized-web #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First try to solve issue #3121
robertcheramy
commented
Feb 2, 2025
| if @gitcache[repo_path][:nodes][filename] | ||
| # using the splat operator (*) should be OK as hashlist should | ||
| # not be very big when working on deltas | ||
| @gitcache[repo_path][:nodes][filename].prepend(*hashlist) |
There was a problem hiding this comment.
@ytti - do you have experience or an opinion on using the splat operator for prepending an array to an array?
There are alternatives to the splat operator, but I found this to be the most readable and efficient.
I read that when the array is smaller than 1000 entries, the splat operator is not a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
In order to address the performance issues observed in oxidzed-web when listing the versions of a node, this PR caches git log into memory. At the first time, we still have a slow performance, subsequent calls only need to scan new commits and are very much faster.
Closes issue #3121