Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alleged Domain Driven Design / Dependency Injection and other things #6

Merged
merged 16 commits into from
Aug 28, 2020

Conversation

rmil
Copy link
Member

@rmil rmil commented Aug 28, 2020

This branch was mostly focused on refactoring the code-base and taking advantage of dependency injection to decouple the packages from each other and made it more modular and hopefully easier to test. However, more refactoring will need to be done since I'm not satisfied with how the service packages are laid out and want to standardise on a certain style and also decide on passing by value / pointer. Hopefully I'll be able to resolve them later.

So this branch includes:

  • Refactoring
    • Removed all global variables, introducing interfaces which will hopefully make it easier to develop for. Refactor infrastructure layer #3
    • Removed the logging package from all service/handler packages and improved greatly error handling Better logging #4
    • Find by path now separated from creator package for public usage
  • Features
    • Quotes get/new/update
    • New sign-up sheets
    • Playlist update including playlist video items
  • Fixes
    • Lack of arrival time for sign-up sheets
    • Incorrect errors being returned

@rmil rmil self-assigned this Aug 28, 2020
@rmil rmil merged commit 550b456 into master Aug 28, 2020
@rmil rmil deleted the DDD branch August 28, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant