Supporting changes for the WTF #186 PR #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for Bochs' disassemble module - Added support for bxInstruction's dst/src functions
- Added APIs to resolve instruction operand's address - CPU: set/get reg16/reg32
- Added APIs to resolve instruction's seg, and operation mode - Exported a function, to get total number of GPRs
`c_unwind` has been stabilized in 1.71.0
Equivalent of cmake `RelWithDebInfo`
Add `release-with-debuginfo` Cargo profile
yrp604
requested changes
Oct 15, 2023
| @@ -628,6 +665,30 @@ impl Cpu { | |||
|
|
|||
| // gp regs | |||
|
|
|||
| pub unsafe fn get_reg64(&self, reg: GpRegs) -> u64 { | |||
There was a problem hiding this comment.
nit: if this is exposed by the rust api it should be reg64()/set_reg64 to be consistent with the rest of the files in this function. get/set are used that the cabi layer
| 14 => GpRegs::R14, | ||
| 15 => GpRegs::R15, | ||
| // @TODO: Should we panic here? | ||
| _ => panic!("Invalid GpRegs"), |
There was a problem hiding this comment.
panic is fine, can you include the reg num in the panic msg though?
| printf("const BX_IA_CMP_AXIw: u32 = %#x;\n", BX_IA_CMP_AXIw); | ||
| printf("const BX_IA_CMP_EwIw: u32 = %#x;\n", BX_IA_CMP_EwIw); | ||
| printf("const BX_IA_CMP_EwsIb: u32 = %#x;\n", BX_IA_CMP_EwsIb); | ||
| unsigned opcode_disasm_wrapper(bool is_32, bool is_64, bx_address cs_base, |
There was a problem hiding this comment.
I haven't gone through the wtf pr, but why do we need to expose the bx disassembler?
| // to resolve the address of the instruction. I could not find | ||
| // any other way to do this, so I'm just going to use it here. | ||
|
|
||
| // Soooo, yeah, this is a bit of a hack. We can't simply use |
|
|
||
| // void instr_dmp() { |
There was a problem hiding this comment.
do you think there is any point in keeping this once this PR is merged? it's only use is a very hack-y version of a thing youre replacing right? if so, feel free to delete...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting changes for the: 0vercl0k/wtf#186