Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for S2125 #210

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

martijnrusschen
Copy link
Contributor

Ref #209

I've downloaded the full modbus export from my S2125 (used with VVM S320) which is running on the latest version (V3.5.5).

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (598a05f) to head (3bc31ff).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   70.17%   70.17%           
=======================================
  Files          14       14           
  Lines        1358     1358           
=======================================
  Hits          953      953           
  Misses        405      405           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yozik04
Copy link
Owner

yozik04 commented Jan 23, 2025

But I think you have deleted a lot of registers which are not active on your system. I'd keep them.

@martijnrusschen
Copy link
Contributor Author

Hmm, I had 2 options:

  1. export most used
  2. export all

I exported all but happy to bring back all deleted ones.

@yozik04
Copy link
Owner

yozik04 commented Jan 23, 2025

I usually just modify existing lines, append new ones and keep what is missing. Deduplication might be required, but the tool prints hints.

@martijnrusschen
Copy link
Contributor Author

ok let me fix that today

@martijnrusschen
Copy link
Contributor Author

@yozik04 is this more in line with what you were looking for?

@yozik04 yozik04 merged commit e3d5fc0 into yozik04:master Jan 24, 2025
8 checks passed
@yozik04
Copy link
Owner

yozik04 commented Jan 24, 2025

Thank you @martijnrusschen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants