-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for S2125 #210
Updates for S2125 #210
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 70.17% 70.17%
=======================================
Files 14 14
Lines 1358 1358
=======================================
Hits 953 953
Misses 405 405 ☔ View full report in Codecov by Sentry. |
But I think you have deleted a lot of registers which are not active on your system. I'd keep them. |
Hmm, I had 2 options:
I exported all but happy to bring back all deleted ones. |
I usually just modify existing lines, append new ones and keep what is missing. Deduplication might be required, but the tool prints hints. |
ok let me fix that today |
@yozik04 is this more in line with what you were looking for? |
Thank you @martijnrusschen |
Ref #209
I've downloaded the full modbus export from my S2125 (used with VVM S320) which is running on the latest version (V3.5.5).