-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registers for Pool 40 accessory and some more missing registers to S1156/S1256 #204
Merged
yozik04
merged 7 commits into
yozik04:master
from
vtamm:add-pool-40-and-other-missing-registers-to-s1156-and-s1256
Jan 15, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b234647
Add registers for Pool 40 accessory to S1156 and S1256
vtamm 6d1e384
Convert source s1156_s1256.csv to JSON, adding Pool 40 registers
vtamm 267cda5
Add missing S1156/S1256 registers
vtamm 8cebbe4
Convert source s1156_s1256.csv to JSON, adding previously missing reg…
vtamm 92a9c4d
Revert change to S1156/S1256 JSON file (not permitted) and add an ext…
vtamm 0b04ff8
Remove unnecessary extension for changed default value in CSV export
vtamm 1cd3f96
Add registers for wireless accessories to S1156/S1256
vtamm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yozik04 regarding this line and why it is "new": I see that you had a discussion recently about adding this register. It was then added to
s1155_s1255.csv
in #197 but then it seems the "Hot water start" was lost for the xx56 models when the news1156.csv
file was added in #198 and later renamed tos1156_s1256.csv
in this commit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can just drop
extensions.json
change, regenerate json file and it will be fine to merge. Of course tests need to pass =)