Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we get a logged path when parsing fails. #170

Merged
merged 3 commits into from
Jul 27, 2024

Conversation

elupus
Copy link
Collaborator

@elupus elupus commented Jul 26, 2024

  • Drop compiled parsers, speed here is not that important, it's better to know what things fails.
  • Use a focusted sequence and switch to select the message type so the parsing path is fixed

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.96%. Comparing base (71d6bfb) to head (b799ba6).
Report is 1 commits behind head on master.

Files Patch % Lines
nibe/console_scripts/cli.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   57.96%   57.96%           
=======================================
  Files          14       14           
  Lines        1261     1261           
=======================================
  Hits          731      731           
  Misses        530      530           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yozik04
Copy link
Owner

yozik04 commented Jul 27, 2024

It was not about speed but about consuming memory and CPU. I see that FocusedSeq does not support compiling.

@yozik04 yozik04 merged commit 063745d into yozik04:master Jul 27, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants