Correct parsing of RMU data fields #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
elupus
commented
Jan 2, 2024
elupus
commented
- Setting RMU target temperature needs 16 bit signed values
- Setpoint for offsets with RMU does not have any scaling applied
- Correct jump of outdoor temperature when received from RMU since pump seem to apply the scaling in reverse
Turns out these have no scaling
It seems the pump applies offset in reverse when values become negative. It is very much unclear why this occurs, but live data has been seen that jumps from 0.0 to -1.1 which is the double offset.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 57.46% 57.72% +0.26%
==========================================
Files 14 14
Lines 1213 1230 +17
==========================================
+ Hits 697 710 +13
- Misses 516 520 +4 ☔ View full report in Codecov by Sentry. |
|
Do you want to cover encode as well with a test? |
|
Yes probably. Will look at it. I think some back to back roundtrip testing of decode/encode would be enough there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.