Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all construct parse errors the same #142

Merged
merged 2 commits into from
Jan 1, 2024

Conversation

elupus
Copy link
Collaborator

@elupus elupus commented Jan 1, 2024

Handle all construct parse errors the same

  • Logs all parse errors without backtrace
  • Adjust invalid logger format for standard exceptions

- Logs all parse errors without backtrace
- Adjust invalid logger format for standard exceptions
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (756a793) 57.60% compared to head (7c3322e) 57.46%.

Files Patch % Lines
nibe/console_scripts/cli.py 0.00% 6 Missing ⚠️
nibe/connection/nibegw.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   57.60%   57.46%   -0.15%     
==========================================
  Files          14       14              
  Lines        1210     1213       +3     
==========================================
  Hits          697      697              
- Misses        513      516       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yozik04 yozik04 merged commit 4b109e4 into yozik04:master Jan 1, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants