Remove fallback check and add test

yozik04 · Nov 10, 2024 · f79e6e3 · f79e6e3
1 parent 6dab103
commit f79e6e3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/nibe/connection/nibegw.py b/nibe/connection/nibegw.py
@@ -189,8 +189,6 @@ def datagram_received(self, data: bytes, addr):
             with io.BytesIO(bytes(data)) as stream:
                 while block := Block.parse_stream(stream):
                     self._on_block(block, addr)
-                if remaining := stream.read():
-                    logger.warning("Failed to parse: %s", remaining)
         except ConstructError as e:
             logger.warning(
                 f"Ignoring packet from {addr} due to parse error: {hexlify(data).decode('utf-8')}: {e}"

diff --git a/tests/connection/test_nibegw.py b/tests/connection/test_nibegw.py
@@ -151,6 +151,20 @@ async def test_read_product_info(nibegw: NibeGW):
     assert "F1255-12 R" == product.model
 
 
+async def test_read_product_info_with_extras(nibegw: NibeGW):
+    _enqueue_datagram(
+        nibegw,
+        "5c0019ee00f7"  # token accessory version
+        "c0ee03ee0101c3"  # accessory version from accessory
+        "06"  # ack from pump
+        "5c00206d0d0124e346313235352d313220529f",
+    )
+    product = await nibegw.read_product_info()
+
+    assert isinstance(product, ProductInfo)
+    assert "F1255-12 R" == product.model
+
+
 @pytest.mark.parametrize(
     ("raw", "table_processing_mode", "calls"),
     [