Skip to content

Commit

Permalink
Convert SMO40 filter time to numeric value (#79)
Browse files Browse the repository at this point in the history
This PR converts `Outdoor Filter Time` to a numerical value instead of
an enum. For SMO40 this binding allows for any value between `1-48` as
discussed in #77, setting this to an enum seems to be a copy paste
mistake somewhere (Nibe themselves?). If you feel more heatpumps should
support this, please feel free to add them.

This PR is dependent on #78.
  • Loading branch information
yozik04 authored Dec 22, 2022
2 parents c722051 + d8bc3a3 commit cf44cbe
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 6 deletions.
12 changes: 12 additions & 0 deletions nibe/data/extensions.json
Original file line number Diff line number Diff line change
Expand Up @@ -226,5 +226,17 @@
"unit": "A"
}
}
},
{
"description": "Allow for numerical selection for Outdoor Filter Time",
"files": [
"smo40.json"
],
"data": {
"47377": {
"size": "s16",
"mappings": null
}
}
}
]
8 changes: 2 additions & 6 deletions nibe/data/smo40.json
Original file line number Diff line number Diff line change
Expand Up @@ -7394,17 +7394,13 @@
"title": "Outdoor Filter Time",
"info": " 12=12 Hours 24=24 Hours",
"unit": "h",
"size": "u8",
"size": "s16",
"factor": 1,
"min": 0.0,
"max": 48.0,
"default": 24.0,
"name": "outdoor-filter-time-47377",
"write": true,
"mappings": {
"12": "12 Hours",
"24": "24 Hours"
}
"write": true
},
"47378": {
"title": "Max diff. comp.",
Expand Down

0 comments on commit cf44cbe

Please sign in to comment.