Allow read of CoilData with missing mappings (#172)

Fallback to `UNKNOWN (int)`.

Writes should fail.

nibe/coil.py

@@ -178,7 +178,10 @@ def __repr__(self) -> str:
     @staticmethod
     def from_mapping(coil: Coil, value: int) -> "CoilData":
         """Create CoilData from raw value using mappings."""
-        return CoilData(coil, coil.get_mapping_for(value))
+        try:
+            return CoilData(coil, coil.get_mapping_for(value))
+        except NoMappingException:
+            return CoilData(coil, f"UNKNOWN ({value})")
 
     @staticmethod
     def from_raw_value(coil: Coil, value: Union[int, None]) -> "CoilData":

nibe/connection/nibegw.py

@@ -469,9 +469,10 @@ def _on_coil_value(self, coil_address: int, value: Union[float, int, str]) -> No
                 value = int(value)
 
             if coil.has_mappings and isinstance(value, int):
-                value = coil.get_mapping_for(value)
+                coil_data = CoilData.from_mapping(coil, value)
+            else:
+                coil_data = CoilData(coil, value)
 
-            coil_data = CoilData(coil, value)
             logger.info(coil_data)
             self._on_coil_read_success(coil_data)
         except NibeException as e:

tests/connection/test_nibegw.py

@@ -8,7 +8,7 @@
 
 from nibe.coil import CoilData
 from nibe.connection.nibegw import ConnectionStatus, NibeGW
-from nibe.exceptions import ReadException, ReadTimeoutException, WriteException
+from nibe.exceptions import NoMappingException, ReadTimeoutException, WriteException
 from nibe.heatpump import HeatPump, Model, ProductInfo
 
 
@@ -95,9 +95,12 @@ async def test_read_coil_decode_failed(
     _enqueue_datagram(nibegw, "5c00206a064ea8f51200004d")
 
     start = time.time()
-    with pytest.raises(ReadException) as excinfo:
-        await nibegw.read_coil(coil, timeout=0.1)
-        assert "Decode failed" in str(excinfo.value)
+    data = await nibegw.read_coil(coil, timeout=0.1)
+    assert data.value == "UNKNOWN (245)"
+
+    with pytest.raises(NoMappingException):
+        data.validate()
+
     assert 1 == transport.sendto.call_count
     duration = time.time() - start
     assert duration <= 0.1

tests/test_coil.py

@@ -5,7 +5,12 @@
 
 from nibe.coil import Coil, CoilData
 from nibe.connection.nibegw import CoilDataEncoderNibeGw
-from nibe.exceptions import DecodeException, EncodeException, ValidationError
+from nibe.exceptions import (
+    DecodeException,
+    EncodeException,
+    NoMappingException,
+    ValidationError,
+)
 from nibe.parsers import swapwords
 
 
@@ -447,8 +452,12 @@ def test_unsigned_u8_mapping_decode(
 def test_unsigned_u8_mapping_decode_exception(
     encoder_word_swap_false: CoilDataEncoderNibeGw, coil_unsigned_u8_mapping: Coil
 ):
-    with pytest.raises(DecodeException):
-        encoder_word_swap_false.decode(coil_unsigned_u8_mapping, b"\x00")
+    coil_data = encoder_word_swap_false.decode(coil_unsigned_u8_mapping, b"\x00")
+
+    assert coil_data.value == "UNKNOWN (0)"
+
+    with pytest.raises(NoMappingException):
+        coil_data.validate()
 
 
 @pytest.mark.parametrize(