-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : run ci in multi env os #374
Conversation
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
==========================================
+ Coverage 46.63% 48.27% +1.64%
==========================================
Files 70 67 -3
Lines 5901 5574 -327
==========================================
- Hits 2752 2691 -61
+ Misses 2846 2590 -256
+ Partials 303 293 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 32 in b5321a4
*/ |
enter is needed here for lint resolution
c94a73d
to
d9369ff
Compare
@sinkyoungdeok Thank you! but it's valid pattern. ref. we dont have to add new line on this failed line. |
i dont know why lint was failed only windows env. |
553f90a
to
ece2134
Compare
It seems to be related to this issue: mgechev/revive#607 |
I think it would be good to close this PR for now and open it later when working again. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #293
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: