Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : run ci in multi env os #374

Closed
wants to merge 3 commits into from

Conversation

Limm-jk
Copy link
Contributor

@Limm-jk Limm-jk commented Jul 29, 2022

What this PR does / why we need it:

  • Workflow that automatically tests according to the environment (windows, ubuntu, macOS) when PR comes in.
  • coverage has uploaded in ubuntu env

Which issue(s) this PR fixes:

Fixes #293

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

github actions will be run like below screenshot

image

Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #374 (553f90a) into main (bbd45e3) will increase coverage by 1.64%.
The diff coverage is n/a.

❗ Current head 553f90a differs from pull request most recent head ece2134. Consider uploading reports for the commit ece2134 to get more accurate results

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   46.63%   48.27%   +1.64%     
==========================================
  Files          70       67       -3     
  Lines        5901     5574     -327     
==========================================
- Hits         2752     2691      -61     
+ Misses       2846     2590     -256     
+ Partials      303      293      -10     
Impacted Files Coverage Δ
server/config.go 38.09% <0.00%> (-6.00%) ⬇️
api/types/updatable_project_fields.go 96.66% <0.00%> (-3.34%) ⬇️
api/types/project.go 100.00% <0.00%> (ø)
server/backend/backend.go 0.00% <0.00%> (ø)
pkg/document/change/checkpoint.go 92.00% <0.00%> (ø)
server/backend/database/mongo/indexes.go 50.00% <0.00%> (ø)
pkg/document/crdt/strings.go
api/types/create_project_fields.go
pkg/document/crdt/object.go
pkg/document/crdt/primitive.go
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@sinkyoungdeok sinkyoungdeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enter is needed here for lint resolution

@hackerwins hackerwins force-pushed the main branch 2 times, most recently from c94a73d to d9369ff Compare August 24, 2022 09:28
@Limm-jk
Copy link
Contributor Author

Limm-jk commented Sep 3, 2022

@sinkyoungdeok Thank you! but it's valid pattern. ref. we dont have to add new line on this failed line.

@Limm-jk
Copy link
Contributor Author

Limm-jk commented Sep 3, 2022

i dont know why lint was failed only windows env.

@Limm-jk Limm-jk force-pushed the feature/multi-env-ci branch from 553f90a to ece2134 Compare September 3, 2022 07:35
@blurfx
Copy link
Member

blurfx commented Sep 5, 2022

It seems to be related to this issue: mgechev/revive#607

@hackerwins
Copy link
Member

I think it would be good to close this PR for now and open it later when working again.

@hackerwins hackerwins closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write Github CI script to test according to environment
5 participants