Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outputs for version #33

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Fix outputs for version #33

merged 1 commit into from
Feb 13, 2025

Conversation

lcheylus
Copy link
Contributor

Fix #32


Tests OK with default version = dev

$ ./heimdall foo
            _               _       _ _
  /\  /\___(_)_ __ ___   __| | __ _| | |
 / /_/ / _ \ | '_ ` _ \ / _` |/ _` | | |
/ __  /  __/ | | | | | | (_| | (_| | | |
\/ /_/ \___|_|_| |_| |_|\__,_|\__,_|_|_|

Version dev

$ ./heimdall env-info
            _               _       _ _
  /\  /\___(_)_ __ ___   __| | __ _| | |
 / /_/ / _ \ | '_ ` _ \ / _` |/ _` | | |
/ __  /  __/ | | | | | | (_| | (_| | | |
\/ /_/ \___|_|_| |_| |_|\__,_|\__,_|_|_|

Version dev (commit d311588), built at 2025-02-13T11:46:47, compiled with go1.23.6
  
+----------+----------+------------------------------------------+
| Heimdall |          |                                          |
|          | version  | dev                                      |
|          | commit   | d311588fb5cbdfbd40108b240ff6fc40f2aa803c |
+----------+----------+------------------------------------------+
| OS       |          |                                          |
|          | type     | linux                                    |
|          | arch     | x86_64                                   |
|          | platform | debian                                   |
|          | family   | debian                                   |
|          | version  | trixie/sid                               |
+----------+----------+------------------------------------------+
| CPU      |          |                                          |
|          | cpu      | Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz  |
|          | model    | 60                                       |
|          | family   | 6                                        |
+----------+----------+------------------------------------------+

Tests OK with build + ldflags

$ go build -v -ldflags '-X github.com/yodamad/heimdall/build.Version=0.5.x'

$ ./heimdall foo
            _               _       _ _
  /\  /\___(_)_ __ ___   __| | __ _| | |
 / /_/ / _ \ | '_ ` _ \ / _` |/ _` | | |
/ __  /  __/ | | | | | | (_| | (_| | | |
\/ /_/ \___|_|_| |_| |_|\__,_|\__,_|_|_|

Version 0.5.x

$ ./heimdall env-info
            _               _       _ _
  /\  /\___(_)_ __ ___   __| | __ _| | |
 / /_/ / _ \ | '_ ` _ \ / _` |/ _` | | |
/ __  /  __/ | | | | | | (_| | (_| | | |
\/ /_/ \___|_|_| |_| |_|\__,_|\__,_|_|_|

Version 0.5.x (commit d311588), built at 2025-02-13T11:46:47, compiled with go1.23.6
  
+----------+----------+------------------------------------------+
| Heimdall |          |                                          |
|          | version  | 0.5.x                                    |
|          | commit   | d311588fb5cbdfbd40108b240ff6fc40f2aa803c |
+----------+----------+------------------------------------------+
| OS       |          |                                          |
|          | type     | linux                                    |
|          | arch     | x86_64                                   |
|          | platform | debian                                   |
|          | family   | debian                                   |
|          | version  | trixie/sid                               |
+----------+----------+------------------------------------------+
| CPU      |          |                                          |
|          | cpu      | Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz  |
|          | model    | 60                                       |
|          | family   | 6                                        |
+----------+----------+------------------------------------------+

Signed-off-by: Laurent Cheylus <[email protected]>
@yodamad yodamad merged commit 81274ff into yodamad:main Feb 13, 2025
2 checks passed
@lcheylus lcheylus deleted the fix-version branch February 13, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug] Differences in output for default version
2 participants